From: Dan Winship Date: Wed, 17 Feb 2010 20:21:51 +0000 (-0500) Subject: st_widget_get_theme_node: g_error if called on an unparented widget X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~10338 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d128cc5af35674a8ec6604820127cb188172a59b;p=gnome-shell.git st_widget_get_theme_node: g_error if called on an unparented widget It's wrong to do anything that requires looking up a widget's style before you add the widget to the stage, since its final style may depend on properties inherited from its parents. st_widget_get_theme_node() used to emit a warning in this case, but many would-be contributors apparently didn't notice. Help them out. https://bugzilla.gnome.org/show_bug.cgi?id=610279 --- diff --git a/src/st/st-widget.c b/src/st/st-widget.c index 4a674c5be..08768f73b 100644 --- a/src/st/st-widget.c +++ b/src/st/st-widget.c @@ -1101,8 +1101,7 @@ st_widget_get_theme_node (StWidget *widget) if (stage == NULL) { - g_warning ("st_widget_get_theme_node called on a widget not in a stage"); - stage = CLUTTER_STAGE (clutter_stage_get_default ()); + g_error ("st_widget_get_theme_node called on a widget not in a stage"); } if (parent_node == NULL)